[Reviewed] fix: add robust permission checks to interactionCreate#35
Open
Ramanand-Shirbhate wants to merge 2 commits into
Open
[Reviewed] fix: add robust permission checks to interactionCreate#35Ramanand-Shirbhate wants to merge 2 commits into
Ramanand-Shirbhate wants to merge 2 commits into
Conversation
TrivCodez
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Item #6 from Issue #21.
Added an early return check in
interactionCreate.jsusinginteraction.appPermissions.has('SendMessages').If the bot is missing permissions, it attempts to send an ephemeral warning to the user. If the permissions are so restrictive that even the reply fails, it catches the error and logs it to the console to prevent the bot from crashing. Built on top of the error handling established in PR #28.