[Reviewed] feat: support guild scoped command deploys#37
Conversation
TrivCodez
left a comment
There was a problem hiding this comment.
Requesting changes due to PR formatting.
The PR description is too minimal for a production-ready codebase. Please structure it following the project's contribution standards:
What should be included:
- What: Clear explanation of the feature - guild-scoped command deployment
- Why: Explain the benefit of supporting GUILD_ID - faster command testing/updates vs global deployment latency
- Changes: Detail the specific files and logic changes
- Testing: How was this verified? The
node --checkline is helpful, but explain what scenarios were covered - Backwards compatibility: Confirm global deployment still works when GUILD_ID is unset
Missing details:
- No explanation of how Routes.applicationGuildCommands differs from global routes
- No documentation of environment variable usage
- No mention of discord.js version compatibility implications
- No testing evidence beyond syntax checking
Please update the PR description with these details before this can be reviewed for merge. The implementation may be fine, but the communication needs to match the standards expected for a production bot handler.
Once updated, this PR can move forward for technical review.
|
Hey @ixhxpns - thanks for the contribution! I've left a review requesting changes primarily around PR description formatting. The implementation itself looks solid (guild-scoped deploy is a great feature addition), but the PR description needs more detail to meet the project's standards for a production-ready codebase. Could you update the PR description with:
Once the description is updated, we can move forward with the technical review and get this merged. The code changes themselves look good at first glance! |
Summary\n- support
GUILD_IDinsrc/deploy-commands.js\n- deploy toRoutes.applicationGuildCommandswhenGUILD_IDis set\n- keep existing global deploy behavior whenGUILD_IDis not set\n\n## Bounty\nResolves Item #8 from #21.\n\n## Verification\n-node --check src/deploy-commands.js\n\nI did not run a live Discord deploy because local Discord credentials are not configured.\n