Skip to content

fix(admin): narrow api key option fields#139

Merged
INONONO66 merged 1 commit into
mainfrom
fix/admin-api-key-options-narrowing
Jun 5, 2026
Merged

fix(admin): narrow api key option fields#139
INONONO66 merged 1 commit into
mainfrom
fix/admin-api-key-options-narrowing

Conversation

@INONONO66

@INONONO66 INONONO66 commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • omit absent admin API key allow-list options instead of passing explicit undefined values
  • keep create/update payloads compatible with exact optional property semantics

Verification

  • ./node_modules/.bin/tsc --noEmit --pretty false --exactOptionalPropertyTypes true 2>&1 | rg "src/admin/api-keys.ts" || true
  • bun test tests/e2e/admin-auth.test.ts tests/unit/security-headers.test.ts
  • ./node_modules/.bin/tsc --noEmit --pretty false
  • git diff --check
  • bun run release-check
  • LSP diagnostics for src/admin/api-keys.ts

Summary by cubic

Only include allowedAccounts and allowedProviders in admin API key create/update calls when provided, instead of passing undefined. This aligns with TypeScript exactOptionalPropertyTypes and avoids unintended overwrites by keeping payloads narrow.

Written for commit 32945aa. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@INONONO66, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 50 minutes and 35 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d0a55b5d-1ce2-42b9-b174-a5691475e329

📥 Commits

Reviewing files that changed from the base of the PR and between 14277b6 and 32945aa.

📒 Files selected for processing (1)
  • src/admin/api-keys.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/admin-api-key-options-narrowing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@INONONO66 INONONO66 merged commit 6171bee into main Jun 5, 2026
3 checks passed
@INONONO66 INONONO66 deleted the fix/admin-api-key-options-narrowing branch June 5, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant