fix(startup): omit unset serve development option#145
Conversation
|
Warning Review limit reached
More reviews will be available in 16 minutes and 47 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
undefinedfor an exact optional fieldVerification
./node_modules/.bin/tsc --noEmit --pretty false --exactOptionalPropertyTypes true 2>&1 | rg "src/index.ts" || truebun test tests/unit/startup.test.ts./node_modules/.bin/tsc --noEmit --pretty falsegit diff --checkbun run release-checksrc/index.ts: no diagnosticsSummary by cubic
Fixes startup by not passing an unset
developmentoption toBun.servein production. We now build shared serve options and only adddevelopmentin non-production, avoidingundefinedon an exact optional field and clearing TypeScript diagnostics with--exactOptionalPropertyTypes.Written for commit 0c7095d. Summary will update on new commits.