Open
Conversation
Author
|
Need to update docker images and installation methods for environmental variables set-up |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@woensug-choi it may be better to not copy the code from https://github.com/srmainwaring/asv_wave_sim into this repo, and just reference the plugin instead, maybe as a module, or a build dependency. Aside from potential maintenance issues in creating a hard fork, the code is GPL3, which would require the code in this repo to also be subject to the same license. |
Author
|
@srmainwaring I shall rewrite as dependency! Thank you for the quick comment! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO Launch
Additional packages you need
ensure the system plugins are found
ensure the gui plugin is found
For current ogre vendor package bug, this is required (July 7, 2025)
Referenced from https://github.com/srmainwaring/asv_wave_sim by @srmainwaring