IONOS(assistant): NC33 fork release (NSW-1069) - #5
Open
printminion-co wants to merge 5 commits into
Open
printminion-co wants to merge 5 commits into
printminion-co wants to merge 5 commits into
Conversation
…e numberOfImages field (cherry picked from commit fa7cca1) Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
mime_content_type() requires stream_cast() support to operate on a stream resource directly. Streams returned by File::fopen() can be wrapped in Icewind\Streams\CallbackWrapper, which does not implement stream_cast(), causing a PHP warning to be logged on every preview/output-file request even though the mime type is still detected correctly. This drains the stream into a temporary file first, then calls mime_content_type() against the file path instead. No behavior change; only removes log noise. Signed-off-by: Simon Holzman <simon.holzman@verizon.net> (cherry picked from commit 3ece3ab) Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de> (cherry picked from commit e522f3c) Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Avoids copying the whole file to disk for mime detection. Reads only the first 4096 bytes into a buffer and uses finfo::buffer() to detect the mime type, which does not require stream_cast() support. Addresses maintainer feedback on nextcloud#592. Signed-off-by: Simon Holzman <simon.holzman@verizon.net> (cherry picked from commit 2be918a) Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de> (cherry picked from commit cc750bd) Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
printminion-co
added a commit
to IONOS-Productivity/ncw-server
that referenced
this pull request
Oct 1, 2026
…S fork, pre-tag) Pre-release pin for build artifact evaluation: upstream v3.5.0 + IONOS delta (incl. NSW-1017 mimetype fix). Replaced by the prerelease tag once the fork PR is merged. PR: IONOS-Productivity/nc-assistant#5 SHA: f23d180e4b1ecf4c56050704613c9d7c7d259f62 Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NC33 IONOS assistant line: upstream
v3.5.0+ rebased IONOS patches (previous base:v2.12.0).ionos-dev-v33= vanillav3.5.0.-x), plus the still-unmerged NSW-1017 fix from IONOS(assistant): fix mimetype detection for task output files (NSW-1017) #4 folded in so the NC33 line carries it.Reconciliation against
v3.5.0None of the #4 commits are in v3.5.0 (checked with
git cherry). The resulting lib/ diff is identical to #4's.Commit hashes are unformatted so GitHub auto-links them.
Consumed by IONOS-Productivity/ncw-server#382 via a submodule bump after merge + tag.
Jira: NSW-1069 (folds NSW-1017)