out-of-the-box support for Astaria's hashing and colorisation of the mapper#194
Open
araskal wants to merge 7 commits intoIRE-Mudlet-Mapping:masterfrom
Open
out-of-the-box support for Astaria's hashing and colorisation of the mapper#194araskal wants to merge 7 commits intoIRE-Mudlet-Mapping:masterfrom
araskal wants to merge 7 commits intoIRE-Mudlet-Mapping:masterfrom
Conversation
added astaria to script - todo: convert room id to allow for hash
Add support for games that operate on hashes (IRE-Mudlet-Mapping#186)
Added support for Astaria's game env and colorisation
vadi2
reviewed
Jun 20, 2024
Contributor
vadi2
left a comment
vadi2
left a comment
There was a problem hiding this comment.
Thanks for the PR! A couple of comments below -
| end | ||
| raiseEvent("mmp clear externals") | ||
| mmp.gotoRoom(closestFeature, dashtype, "room") | ||
| mmp.gotoRoom(closestFeature, dashtype, "area") |
| if gmcp.Room.Info.num then | ||
| centerview(gmcp.Room.Info.num) | ||
| elseif gmcp.Room.Info.roomhash then | ||
| print(tostring(mmp.roomidFromHash(gmcp.Room.Info.roomhash))) |
Contributor
|
@araskal is this good to go? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a fair bit of trial and error this is all working for Astaria - though I am not sure whether there's any issues with other MUD's, I tried to limit any changes.