fix qwen3.5 dynamic-cp#141
Merged
Merged
Conversation
ISEEKYAN
approved these changes
May 18, 2026
AlchemistD
reviewed
May 18, 2026
| from megatron.core.packed_seq_params import PackedSeqParams | ||
| from megatron.core.transformer import MegatronModule | ||
| from megatron.core.transformer.spec_utils import ModuleSpec | ||
| from megatron.core.extensions.transformer_engine import get_thd_partitioned_indices |
There was a problem hiding this comment.
I have a question: from megatron.core.extensions.transformer_engine import get_thd_partitioned_indices doesn't exist in megatron-lm, causing a qwen3.5 error when Verl uses mbridge.
Have you encountered this problem before? Thanks~
Owner
There was a problem hiding this comment.
I have a question:
from megatron.core.extensions.transformer_engine import get_thd_partitioned_indicesdoesn't exist in megatron-lm, causing a qwen3.5 error when Verl uses mbridge. Have you encountered this problem before? Thanks~
@AlchemistD sorry for the compatibility issue, just reverted this PR.
@Thaurun please help with the compatibility, I don't find the get_thd_partitioned_indices in megatron or TE repo now.
ISEEKYAN
added a commit
that referenced
this pull request
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.