feat: add GNOME Wayland support via Mutter and gnome-remote-desktop - #3
Merged
Merged
Conversation
ITx-prash
commented
Sep 7, 2026
ITx-prash
commented
Owner
- Add backend detection to route between X11 and GNOME Wayland
- Implement virtual display extension using Mutter DisplayConfig
- Integrate gnome-remote-desktop for Wayland VNC streaming
- Harden module inclusion guards and remove redundant comments
- Clarify quick start commands across CLI, installer, and README
- Add backend detection to route between X11 and GNOME Wayland
- Implement virtual display extension using Mutter DisplayConfig
- Integrate gnome-remote-desktop for Wayland VNC streaming
- Harden module inclusion guards and remove redundant comments
- Clarify quick start commands across CLI, installer, and README
ITx-prash
requested
a lite review from Copilot
and removed request for
Copilot
September 7, 2026 09:25
There was a problem hiding this comment.
🟡 Changes recommended
There are verified correctness issues in the Wayland stop/error-reporting flow and dependency/version handling that can cause misleading success states or persisting invalid metadata.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds a GNOME Wayland execution path alongside the existing X11 flow, routing display creation and VNC streaming through Mutter/gnome-remote-desktop when running under GNOME on Wayland, and updates docs/UX messaging to reflect the new supported sessions.
Changes:
- Introduces backend detection (
x11vsgnome-wayland) and routes display/VNC logic accordingly. - Adds a GNOME Wayland “extend” implementation via gnome-remote-desktop configuration and service control.
- Updates quick-start/help/docs to use the
--start/--stop/...CLI and to document GNOME-only Wayland support.
File summaries
| File | Description |
|---|---|
| README.md | Updates requirements/feature list and CLI quick-start for GNOME Wayland + X11 support. |
| modules/display-backend.sh | Adds session/backend detection used to route X11 vs GNOME Wayland behavior. |
| modules/display-manager.sh | Routes primary display/virtual display handling based on detected backend. |
| modules/wayland-display-manager.sh | Implements GNOME Wayland virtual display enable/disable using gsettings and Mutter state query. |
| modules/vnc-server.sh | Adds gnome-remote-desktop (grdctl + systemd --user) VNC start/stop path and routes based on backend. |
| modules/system-checker.sh | Updates display compatibility checks and display info gathering for GNOME Wayland. |
| modules/dependency-installer.sh | Splits dependency detection/installation between X11 and GNOME Wayland paths. |
| modules/ui-helpers.sh | Adds a module guard, makes clear non-fatal, and updates header text for Wayland support. |
| modules/config-manager.sh | Adds a module guard and changes how system_version is derived during config load. |
| floweave.sh | Sources new modules and updates help/quick-start messaging and --start/--stop handling. |
| install.sh | Updates installer quick-start text to match floweave --start usage. |
| config/default.conf | Clears the default system.version field to be filled/managed by runtime logic. |
Review details
- Files reviewed: 12/12 changed files
- Comments generated: 5
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ITx-prash
requested
a lite review from Copilot
and removed request for
Copilot
September 7, 2026 10:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.