docs: fix stale re/regex and CI build-step wording from final review - #101
Merged
IceRhymers merged 1 commit intoJul 24, 2026
Conversation
README.md and app/AGENTS.md still said Python `re` in two spots that #38's commit (f27565b) missed when it switched the rescan to the `regex` module elsewhere. webui/frontend/README.md claimed CI does not run a Node build step, which #80's commit (9c4f679) made false by adding make webui-verify-dist to the webui CI job; the point that production deploy doesn't need Node at deploy time is preserved.
IceRhymers
merged commit Jul 24, 2026
8bdef8c
into
integration/search-hardening-and-ci-integrity
4 checks passed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the three documentation-drift corrections identified by the approved final independent integration review (findings 1–3; finding 4 is a process note about PR #96's body, not applied here):
README.md:277—regex_incompatibledescription still said Python`re`; search: bound Python regex CPU per request (web-exposed ReDoS) #38's commit (f27565b) updated the other occurrence in the same file but missed this one. Now reads`regex`.app/AGENTS.md:32— "Never run SQL or the Pythonrerescan inline in an async handler" was stale relative toapp/main.py's own module docstring, which search: bound Python regex CPU per request (web-exposed ReDoS) #38 already updated toregex. Now reads`regex`.webui/frontend/README.md:20— "CI does not run a Node build step for v1" became false once webui: add CI dist-freshness gate for committed frontend build #80's commit (9c4f679) addedmake webui-verify-dist(npm ci && npm run build) to thewebuiCI job. Reworded to state that CI's Node build step exists only to verify the committeddist/is fresh, while preserving the intended point that production deploy itself doesn't require Node.No code, test, or behavior changes — doc wording only, scoped exactly to the three corrections called out by the review.
Test plan
grepconfirms no remaining stalePython \re`orCI does not run a Node build` wording in the three filesgit diff --statagainstorigin/integration/search-hardening-and-ci-integrityshows only the intended 3-file, 5-line diff