Feature/preserve parameter#12
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a preserve parameter and member to the JSONFile class to allow preserving corrupted/invalid JSON files before overwriting them with defaults during recovery operations.
Changes:
- Added
preserveparameter toJSONFile.__init__(),reload(), andrestore_default()methods - Implemented automatic backup functionality that renames existing files to
<filename>.old.<n>.jsonbefore recovery - Added property getter/setter for the preserve instance member
- Updated documentation to describe the preserve feature
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/singlejson/fileutils.py | Implements preserve parameter, backup logic with incremental naming, and refactors restore_default() to consolidate file writing |
| src/singlejson/pool.py | Adds preserve parameter to load() function with documentation |
| tests/test_reload_strict_recover.py | Adds tests for preserve functionality including incremental backup naming |
| tests/test_pool.py | Adds test for preserve parameter in pool.load() |
| docs/source/defaults.rst | Documents the preserve feature and fixes heading underline |
| docs/source/pooling.rst | Documents preserve parameter usage in pool operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix typos and rewrite docstring Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
This closes #11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add preserve parameter and member to JSONFile