Merged
Conversation
Replace the vendored pony-immutable-json dependency with json-ng in pony-lsp. All 15 source files updated to use json-ng's API: chained .update()/.push() instead of Obj/Arr builders, JsonNav for navigation, and errors-as-data parsing via JsonParser.parse(). Also removes the now-unused vendored pony-immutable-json library and increases ponyc's stack size to 8MB on Windows (MSVC /STACK linker flag) to match the Linux default — the reachability pass walks AST trees recursively and overflows the 1MB Windows default on large type graphs like json-ng's. See issue #4855 for the longer-term fix of converting the recursion to iteration.
Temporary directories should be removed when they are no longer needed. Added pony-list-tests for Windows CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.