Merged
Conversation
…les (#4885) The package docstring used `ph.array_eq` which doesn't exist on PropertyHelper — the correct method is `assert_array_eq`. The inline for_all example also had `Usize` (wrong capitalization) and used `arg1` instead of `sample` (the lambda parameter name). Closes #4884
…4886) The rule previously required 2+ consecutive dot-calls to fire. A single call followed by a bare reference to return the variable is equally replaceable with .> chaining, since .> returns the receiver. Lower the threshold so the trailing-ref branch fires with 1+ calls while the no-trailing-ref branch still requires 2+. Refactor instances in pony-lint's own test code that the rule now catches. Closes #4882
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.