Merged
Conversation
Implement style/control-structure-alignment for pony-lint (Phase 3, PR 3 from Discussion #4844). The rule checks that control structure keywords are vertically aligned: if/elseif/else/end, for/else/end, while/else/end, try/else/then/end, repeat/until/else/end, with/end, and ifdef/elseif/else/end. Single-line structures are exempt. Uses a hybrid approach: opening keywords and elseif positions come from the AST, while else/end/until/then positions are found via source text scanning (the parser discards their positions). Forward scanning for end uses full-line depth tracking to handle inline single-line blocks correctly. Design: #4844
…ules (#4890) Two new AST rules for pony-lint that enforce the Pony style guide's formatting requirements for multiline type aliases and array literals. TypeAliasFormat checks multiline union/intersection type aliases for: - Opening `(` as first non-whitespace on its line (no hanging indent) - Space after `(` - Space after `|`/`&` at line starts - Space before `)` ArrayLiteralFormat checks multiline array literals for: - Opening `[` as first non-whitespace on its line - Space after `[` Existing pony-lint source updated to comply with the new array-literal-format rule (space after `[` in multiline array literals throughout). Design: #4844
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.