Skip to content

USD CurvesAlgo, MeshAlgo : Add prim path to warnings #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnhaddon wants to merge 1 commit into
base: RB-10.6
Choose a base branch
from
+20 −4
Open

USD CurvesAlgo, MeshAlgo : Add prim path to warnings #1513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
10.6.x.x (relative to 10.6.3.1)
========

Improvements
------------

- USDScene : Added prim path to warnings when reading curves and meshes.

10.6.3.1 (relative to 10.6.3.0)
========
Expand Down
16 changes: 13 additions & 3 deletions contrib/IECoreUSD/src/IECoreUSD/CurvesAlgo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,11 @@ IECore::ObjectPtr readBasisCurves( pxr::UsdGeomBasisCurves &curves, pxr::UsdTime
}
else
{
IECore::msg( IECore::Msg::Warning, "USDScene", boost::format( "Unsupported basis \"%1%\"" ) % usdBasis );
IECore::msg(
IECore::Msg::Warning, "USDScene",
boost::format( "Unsupported basis \"%1%\" reading \"%2%\"" )
% usdBasis % curves.GetPath()
);
}
}

Expand All @@ -125,7 +129,11 @@ IECore::ObjectPtr readBasisCurves( pxr::UsdGeomBasisCurves &curves, pxr::UsdTime
}
else if( wrap != pxr::UsdGeomTokens->nonperiodic )
{
IECore::msg( IECore::Msg::Warning, "USDScene", boost::format( "Unsupported wrap \"%1%\"" ) % wrap );
IECore::msg(
IECore::Msg::Warning, "USDScene",
boost::format( "Unsupported wrap \"%1%\" reading \"%2%\"" )
% wrap % curves.GetPath()
);
}

return readCurves( curves, time, basis, periodic, canceller );
Expand Down Expand Up @@ -205,7 +213,9 @@ bool writeCurves( const IECoreScene::CurvesPrimitive *curves, const pxr::UsdStag
}
else if ( curves->basis() != CubicBasisf::linear() )
{
IECore::msg( IECore::Msg::Warning, "USDScene", "Unsupported basis" );
IECore::msg(
IECore::Msg::Warning, "USDScene", boost::format( "Unsupported basis writing \"%1%\"" ) % path
);
}

if( !basis.IsEmpty() )
Expand Down
5 changes: 4 additions & 1 deletion contrib/IECoreUSD/src/IECoreUSD/MeshAlgo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,10 @@ IECore::ObjectPtr readMesh( pxr::UsdGeomMesh &mesh, pxr::UsdTimeCode time, const
// within a single crease, rather than just a sharpness per crease. We don't know how
// we would author one of these in practice (certainly not in Maya), and we're not sure
// why we'd want to. For now we ignore them.
IECore::msg( IECore::Msg::Warning, "USDScene", "Ignoring creases with varying sharpness" );
IECore::msg(
IECore::Msg::Warning, "USDScene",
boost::format( "Ignoring creases with varying sharpness on \"%1%\"" ) % mesh.GetPath()
);
}
}

Expand Down