Fix logit scale calculation in zero_shot_iid.py#39
Draft
work4cs wants to merge 1 commit into
Draft
Conversation
Member
|
If this is the correct form, then we'll need to fix this in pybioclip as well. And presumably this doesn't affect ordering after |
Contributor
Author
I am thinking of if double exp(), some values might become too large and overflow. Then, the ranking becomes meaningless and wrong. And probabilities/confidence, yes, it might make the result seems over-confident. |
Member
|
@work4cs is going to explore this more over the weekend before we make any changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bioclip/src/open_clip/model.py
Line 237 in 4ea3247