You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After the F8 uuid4 migration (fix/flashcore-F8), three card fixture docstrings in tests/conftest.py still describe the fixtures as "pre-populated with uuid 11111111-…", "22222222-…", and "33333333-…":
conftest.py:117 — sample_card1 docstring
conftest.py:136 — sample_card2 docstring
conftest.py:154 — sample_card3_deck_b docstring
The fixture bodies now generate str(uuid.uuid4()), so the docstrings are stale prose.
Why deferred
This was surfaced as VERIFIED FACT #2 in the or-review verdict (verdicts/flashcore-F8/or-review.md): "The code is correct; only the prose is stale. No claim asserts the docstrings were updated, so nothing is falsified — flagged as a nice-to-have follow-up." Updating docstrings is classified as stylistic/cosmetic and was explicitly excluded from F8 scope per plan §6: "Type annotations, docstrings, or stylistic improvements beyond the three changed blocks — deferred; not architectural-correctness for this finding."
Acceptance criteria
tests/conftest.py docstrings for sample_card1, sample_card2, sample_card3_deck_b no longer reference the constant UUID literals 11111111-…, 22222222-…, 33333333-….
Docstrings accurately describe that the uuid field is generated dynamically via uuid.uuid4() per invocation.
pytest tests/ -q --tb=short exits 0 with no regressions.
What
After the F8 uuid4 migration (
fix/flashcore-F8), three card fixture docstrings intests/conftest.pystill describe the fixtures as "pre-populated with uuid 11111111-…", "22222222-…", and "33333333-…":conftest.py:117—sample_card1docstringconftest.py:136—sample_card2docstringconftest.py:154—sample_card3_deck_bdocstringThe fixture bodies now generate
str(uuid.uuid4()), so the docstrings are stale prose.Why deferred
This was surfaced as VERIFIED FACT #2 in the or-review verdict (
verdicts/flashcore-F8/or-review.md): "The code is correct; only the prose is stale. No claim asserts the docstrings were updated, so nothing is falsified — flagged as a nice-to-have follow-up." Updating docstrings is classified as stylistic/cosmetic and was explicitly excluded from F8 scope per plan §6: "Type annotations, docstrings, or stylistic improvements beyond the three changed blocks — deferred; not architectural-correctness for this finding."Acceptance criteria
tests/conftest.pydocstrings forsample_card1,sample_card2,sample_card3_deck_bno longer reference the constant UUID literals11111111-…,22222222-…,33333333-….uuidfield is generated dynamically viauuid.uuid4()per invocation.pytest tests/ -q --tb=shortexits 0 with no regressions.References
.openclaw/workspace/orchestration/fix/.work/verdicts/flashcore-F8/or-review.md.aiv/plans/flashcore-F8-plan.md§6