Skip to content

chore(core,vm): drop the two dead extension includes and 29 stale externs (#744, items 1-2) #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
InauguralPhysicist merged 1 commit into from
Aug 2, 2026
Merged

chore(core,vm): drop the two dead extension includes and 29 stale externs (#744, items 1-2) #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/eigenscript.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,6 @@
#include "vm.h" /* EigsChunk layout: the cycle collector traverses
* fn -> chunk -> env_cache / functions[] edges */
#include <pthread.h>
#if EIGENSCRIPT_EXT_DB
#include "ext_db_internal.h"
#endif
#if EIGENSCRIPT_EXT_MODEL
#include "model_internal.h"
#endif

/* #298 follow-up: surface use-after-recycle on the per-thread Value/Env
* freelists to Valgrind. A num/env whose refcount hits 0 is recycled onto a
Expand Down
47 changes: 11 additions & 36 deletions src/vm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,42 +297,17 @@ static int vm_slot_value_opaque(Env *e, int idx) {
* fields; the g_* identifiers are macros in eigenscript.h. No extern
* decls needed here. */

/* ---- Helpers from eigenscript.c ---- */
extern void val_incref(Value *v);
extern void val_decref(Value *v);
extern Value* make_num(double n);
extern Value* make_str(const char *s);
extern Value* make_null(void);
extern Value* make_list(int cap);
extern Value* make_dict(int cap);
extern Value* make_fn(const char *name, char **params, int param_count,
Env *closure);
extern Value* make_builtin(Value* (*fn)(Value*));
extern void list_append(Value *list, Value *item);
extern void dict_set(Value *dict, const char *key, Value *val);
extern Value* dict_get(Value *dict, const char *key);
extern Env* env_new(Env *parent);
extern void env_incref(Env *env);
extern void env_decref(Env *env);
extern void env_mark_captured(Env *env);
extern void env_reserve_slots(Env *env, int total);
extern void env_set_local(Env *env, const char *name, Value *val);
extern void env_set_hashed(Env *env, const char *name, uint32_t h, Value *val);
extern void env_set_local_hashed(Env *env, const char *name, uint32_t h, Value *val);
extern Value* env_get_hashed(Env *env, const char *name, uint32_t h);
extern Value* env_get(Env *env, const char *name);
extern double num_guard(double x);
extern Value* promote_if_arena(Value *v);
/* Observer helper — declared in eval.c, needs to be exposed for VM.
* For now, call the eval.c version via a non-static wrapper. */
extern void observer_ensure_fresh(Value *v);
extern Value* builtin_free_val(Value *arg);
extern const char* val_type_name(ValType t);
extern Value* dict_get_hashed(Value *dict, const char *key, uint32_t h);
extern void dict_set_hashed(Value *dict, const char *key, uint32_t h, Value *val);
extern int env_hash_find_dict(Value *dict, const char *key, uint32_t h);
extern int env_get_assign_count(Env *env, const char *name, uint32_t h);
extern void env_hash_insert(EnvHash *ht, uint32_t h, int idx);
/* ---- Cross-TU helpers that no header declares (#744) ----
* The value/env/dict constructors and accessors this file calls are all
* declared in eigenscript.h — the re-declarations that used to sit here
* were redundant copies free to drift from it (one still claimed
* `observer_ensure_fresh` came from eval.c, a TU the bytecode VM replaced,
* and `val_incref`/`val_decref`/`num_guard` are `static inline` in the
* header, so the extern was inert). These three are the ones with no
* header declaration to defer to; they stay until they get a home. */
extern Value* builtin_free_val(Value *arg); /* builtins.c */
extern int env_hash_find_dict(Value *dict, const char *key, uint32_t h); /* eigenscript.c */
extern int env_get_assign_count(Env *env, const char *name, uint32_t h); /* eigenscript.c */

/* Inline fast-path for binding a single param into a fresh call env.
* Caller guarantees `env->count == slot_idx` and `env->capacity > slot_idx`
Expand Down
Loading