fix(energy): stop battery and cable taking forever to mine - #839
Open
Indemnity83 wants to merge 1 commit into
Open
fix(energy): stop battery and cable taking forever to mine#839Indemnity83 wants to merge 1 commit into
Indemnity83 wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR updates battery and cable block properties. Batteries now require pickaxes for mining and correct tool drops. Cables use no map color and lower block strength. ChangesPower block properties
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mc/1.21.1 #839 +/- ##
===============================================
- Coverage 22.23% 22.23% -0.01%
Complexity 2229 2229
===============================================
Files 560 560
Lines 24623 24624 +1
Branches 3684 3684
===============================================
Hits 5476 5476
- Misses 18731 18732 +1
Partials 416 416
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Battery and power Cables (copper/gold/ender) had no correct-tool tag, so a pickaxe gave no mining-speed bonus against them — breaking either was much slower than intended, tool or no tool.
Changes
requiresCorrectToolForDrops()and register it in themineable/pickaxetag, matching every other machine/engine block (mirrors the Steam Engine, which shares its 3.0 hardness).mapColor(NONE)to match the Pipe blocks' properties exactly, so it breaks just as fast by hand as a pipe does. Per-tier sounds (copper/gold/ender) are unchanged.Notes
Will forward-port to mc/1.21.11, mc/26.1, mc/26.2, and mc/26.3 once this merges.