fix(automation): accept raw ore in the quicksilver amalgamation recipes - #840
Open
Indemnity83 wants to merge 1 commit into
Open
fix(automation): accept raw ore in the quicksilver amalgamation recipes#840Indemnity83 wants to merge 1 commit into
Indemnity83 wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdded three alloy smelter recipes that combine quicksilver with raw copper, raw gold, or raw tin. Each recipe produces three primary ingots and uses 4000 energy. The recipes define distinct byproducts. ChangesQuicksilver alloy recipes
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Alloy Smelter's quicksilver amalgamation recipes (Copper, Gold, Tin — Iron has no quicksilver variant) only accepted the ore block (
c:ores/<metal>), not the loose raw ore item most players actually mine. Same root cause as #838: the raw item form of an ore was never wired up as valid input.Changes
c:raw_materials/<metal>convention tag:copper_from_raw_copper_quicksilver.jsongold_from_raw_gold_quicksilver.jsontin_from_raw_tin_quicksilver.jsonNotes
Will forward-port to mc/1.21.11, mc/26.1, mc/26.2, and mc/26.3 once this merges.