Skip to content

fix(automation): accept raw ore in the quicksilver amalgamation recipes - #840

Open
Indemnity83 wants to merge 1 commit into
mc/1.21.1from
alloy-smelter-raw-ore-quicksilver-recipes
Open

fix(automation): accept raw ore in the quicksilver amalgamation recipes#840
Indemnity83 wants to merge 1 commit into
mc/1.21.1from
alloy-smelter-raw-ore-quicksilver-recipes

Conversation

@Indemnity83

Copy link
Copy Markdown
Owner

Summary

The Alloy Smelter's quicksilver amalgamation recipes (Copper, Gold, Tin — Iron has no quicksilver variant) only accepted the ore block (c:ores/<metal>), not the loose raw ore item most players actually mine. Same root cause as #838: the raw item form of an ore was never wired up as valid input.

Changes

  • Add raw-ore counterparts for the three existing quicksilver recipes, using the parallel c:raw_materials/<metal> convention tag:
    • copper_from_raw_copper_quicksilver.json
    • gold_from_raw_gold_quicksilver.json
    • tin_from_raw_tin_quicksilver.json
  • Same output and byproduct as the ore-block recipe in each case (raw copper/gold/tin + quicksilver → 3 ingots + the same chanced byproduct).

Notes

Will forward-port to mc/1.21.11, mc/26.1, mc/26.2, and mc/26.3 once this merges.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4ce8b6f0-a5e0-484d-a8be-63a35c0e1248

📥 Commits

Reviewing files that changed from the base of the PR and between a2dc8c3 and 18feb24.

📒 Files selected for processing (3)
  • common/src/main/resources/data/logistics/recipe/alloy_smelter/copper_from_raw_copper_quicksilver.json
  • common/src/main/resources/data/logistics/recipe/alloy_smelter/gold_from_raw_gold_quicksilver.json
  • common/src/main/resources/data/logistics/recipe/alloy_smelter/tin_from_raw_tin_quicksilver.json

📝 Walkthrough

Walkthrough

Added three alloy smelter recipes that combine quicksilver with raw copper, raw gold, or raw tin. Each recipe produces three primary ingots and uses 4000 energy. The recipes define distinct byproducts.

Changes

Quicksilver alloy recipes

Layer / File(s) Summary
Add quicksilver alloy recipes
common/src/main/resources/data/logistics/recipe/alloy_smelter/*_from_raw_*_quicksilver.json
The copper recipe produces three copper ingots and a guaranteed gold ingot. The gold recipe produces three gold ingots and has a 75% rich slag output chance. The tin recipe produces three tin ingots and a guaranteed iron ingot. All recipes use 4000 energy.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the raw-ore recipe additions and their purpose.
Title check ✅ Passed The title clearly and concisely identifies the main change: accepting raw ore in quicksilver amalgamation recipes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch alloy-smelter-raw-ore-quicksilver-recipes

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant