[Bugfix] auto-uninstall utils when uninstalling nvfd

[ricky-chaoju]

Summary

• Uninstall script now auto-detects installed utils files and removes them, preventing orphaned fan-control services after nvfd uninstall
• Removed --with-utils flag from uninstall.sh (no longer needed)
• Makefile uninstall target now also cleans up utils files

Follow-up from PR #9 discussion — previously, if a user installed with --with-utils but uninstalled without it, the fan-control service could be left behind and keep failing due to missing nvfd.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where fan-control services could be left behind after nvfd was uninstalled, leading to persistent errors. The changes introduce an improved uninstallation mechanism that automatically identifies and removes associated utility scripts and services, streamlining the cleanup process and preventing residual components from remaining on the system.

Highlights

• Automatic Utility Uninstallation: The uninstall script now automatically detects and removes installed utility files, such as nvfd-fan-control.sh and its associated service, preventing orphaned services after nvfd uninstallation.
• Simplified Uninstall Script: The --with-utils flag has been removed from uninstall.sh as it is no longer needed due to the new auto-detection logic.
• Makefile Integration: The Makefile's uninstall target has been updated to also clean up utility files, ensuring a comprehensive removal process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• Makefile
  • Added rm -f commands to the uninstall target for nvfd-fan-control.sh and nvfd-fan-control.service.
• scripts/uninstall.sh
  • Removed the WITH_UTILS variable and the --with-utils argument parsing.
  • Updated the --help message to reflect the automatic uninstallation of utilities.
  • Modified the utility removal logic to auto-detect the presence of nvfd-fan-control.sh or nvfd-fan-control.service files before attempting to remove them.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue where utility files could be left behind after uninstalling nvfd. The changes in Makefile and scripts/uninstall.sh correctly solve this by ensuring the utils are always removed as part of the main uninstall process. The removal of the --with-utils flag and the move to auto-detection in uninstall.sh is a solid improvement. I have one suggestion for the Makefile to improve maintainability by reducing code duplication.