Open
Conversation
Collaborator
|
不建议分开放新旧设置，新设置对触控支持基本没有...
…---原始邮件---
发件人: ***@***.***>
发送时间: 2026年3月11日(周三) 晚上10:12
收件人: ***@***.***>;
抄送: ***@***.***>;
主题: [InkCanvasForClass/community] 为托盘右键菜单添加设置入口 (PR #405)
变更说明
本 PR 为托盘右键菜单补齐两个设置入口，分别支持：
打开新设置
打开旧设置（MainWindow.xaml 内的旧设置面板）
具体修改
在 Ink Canvas/App.xaml 中新增两个托盘菜单项：
OpenNewSettingsTrayIconMenuItem（打开新设置）
OpenOldSettingsTrayIconMenuItem（打开旧设置）
在 Ink Canvas/MainWindow_cs/MW_TrayIcon.cs 中新增对应事件处理：
OpenNewSettingsTrayIconMenuItem_Clicked：调用现有 BtnOpenNewSettings_Click
OpenOldSettingsTrayIconMenuItem_Clicked：调用现有 BtnSettings_Click（旧设置入口）
抽出并复用托盘打开设置前的窗口准备逻辑：
若主窗口被隐藏/最小化，先恢复显示
若“隐藏ICC主窗口”处于勾选状态，先取消勾选
激活主窗口后再打开对应设置
同步修复一个托盘菜单定位脆弱点：
将 SysTrayMenu_Opened 中对“隐藏ICC主窗口”菜单项的按索引取值改为按 Name 查找
避免菜单结构新增项后出现错位风险
变更影响
仅影响托盘菜单中的设置入口与相关分发逻辑
不改变新设置/旧设置原有功能实现
其他托盘功能保持不变
手动验证建议
托盘右键应出现“打开新设置 / 打开旧设置”两个选项
点击“打开新设置”应进入新设置窗口
点击“打开旧设置”应打开旧设置面板
在“隐藏ICC主窗口”已勾选、或主窗口最小化时，上述两项仍可正常唤起对应设置
You can view, comment on, or merge this pull request online at:
#405
Commit Summary
700aa08 软件设置内的贡献者列表添加了 PANDA-JSR
bb4b8f4 Merge branch 'InkCanvasForClass:beta' into beta
602fe48 Merge branch 'InkCanvasForClass:beta' into beta
051509f feat(tray): add separate entries for new/legacy settings
File Changes
(2 files)
M Ink Canvas/App.xaml (20)
M Ink Canvas/MainWindow_cs/MW_TrayIcon.cs (92)
Patch Links:
https://github.com/InkCanvasForClass/community/pull/405.patch
https://github.com/InkCanvasForClass/community/pull/405.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Member
|
建议改为打开设置，去掉新设置的打开 |
Contributor
Author
回家有空就改，现在在天津，没有 Windows 电脑 |
Collaborator
|
你现在应该可以拿codespace先改了
…---原始邮件---
发件人: ***@***.***>
发送时间: 2026年3月14日(周六) 晚上6:14
收件人: ***@***.***>;
抄送: ***@***.******@***.***>;
主题: Re: [InkCanvasForClass/community] 为托盘右键菜单添加设置入口 (PR #405)
PANDAJSR left a comment (InkCanvasForClass/community#405)
建议改为打开设置，去掉新设置的打开
回家有空就改，现在在天津，没有 Windows 电脑
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
Contributor
Author
我带了 Mac，那跟我用 Mac 改的区别是啥？ |
Collaborator
|
不能运行，但是可以用dotnet build
…---原始邮件---
发件人: ***@***.***>
发送时间: 2026年3月14日(周六) 晚上6:26
收件人: ***@***.***>;
抄送: ***@***.******@***.***>;
主题: Re: [InkCanvasForClass/community] 为托盘右键菜单添加设置入口 (PR #405)
PANDAJSR left a comment (InkCanvasForClass/community#405)
你现在应该可以拿codespace先改了
---原始邮件---
发件人: @.>
发送时间: 2026年3月14日(周六) 晚上6:14
收件人: @.>;
抄送: @.@.>;
主题: Re: [InkCanvasForClass/community] 为托盘右键菜单添加设置入口 (PR #405)
PANDAJSR left a comment (#405)
建议改为打开设置，去掉新设置的打开
回家有空就改，现在在天津，没有 Windows 电脑
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>
我带了 Mac，那跟我用 Mac 改的区别是啥？
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
Collaborator
之前ce必须用msbuild构建，不能交叉编译的 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明
本 PR 为托盘右键菜单补齐两个设置入口，分别支持：
MainWindow.xaml内的旧设置面板）具体修改
Ink Canvas/App.xaml中新增两个托盘菜单项：OpenNewSettingsTrayIconMenuItem（打开新设置）OpenOldSettingsTrayIconMenuItem（打开旧设置）Ink Canvas/MainWindow_cs/MW_TrayIcon.cs中新增对应事件处理：OpenNewSettingsTrayIconMenuItem_Clicked：调用现有BtnOpenNewSettings_ClickOpenOldSettingsTrayIconMenuItem_Clicked：调用现有BtnSettings_Click（旧设置入口）SysTrayMenu_Opened中对“隐藏ICC主窗口”菜单项的按索引取值改为按 Name 查找变更影响
手动验证建议