Conversation
This reverts commit f7aa107.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2dd804707
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| // 屏幕截图 | ||
| using (var originalBitmap = CaptureScreenAreaWithOptionalInk(screenshotResult.Value.Area, screenshotResult.Value.IncludeInk)) | ||
| using (var originalBitmap = CaptureScreenArea(screenshotResult.Value.Area)) |
There was a problem hiding this comment.
In CaptureScreenshotAndInsert, the capture call was switched to CaptureScreenArea(...), but this method no longer hides the main window before grabbing pixels. Because the window is restored immediately after selector close (before this call), the app chrome/toolbar/ink overlay can be captured into the inserted screenshot when it overlaps the selected region. This regresses the documented behavior of avoiding self-capture in the insert workflow.
Useful? React with 👍 / 👎.
| } | ||
|
|
||
| using (var originalBitmap = CaptureScreenAreaWithOptionalInk(screenshotResult.Area, screenshotResult.IncludeInk)) | ||
| using (var originalBitmap = CaptureScreenArea(screenshotResult.Area)) |
There was a problem hiding this comment.
AddScreenshotToNewWhiteboardPage now captures with CaptureScreenArea(...) directly, which assumes callers already hid the main window. That assumption is false for the CaptureScreenshotAndInsert caller (it restores visibility before dispatching to this method), so choosing “添加到白板” from the selector can include the app UI in the captured image. The capture step should hide the window (or use a helper that does) to keep behavior consistent across callers.
Useful? React with 👍 / 👎.
1 participant
Reverts #406