Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df251b76ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (isPalmEraserActive) | ||
| { | ||
| isPalmEraserActive = false; |
There was a problem hiding this comment.
When the last touch is released, this block only clears isPalmEraserActive and never restores inkCanvas.EditingMode from EraseByPoint. Because PreviewTouchDown now returns early whenever mode is EraseByPoint and isPalmEraserActive is false, touch input can get stuck after one palm-erase gesture (no further touch inking/gesture handling until another path changes the mode). Persist and restore the pre-palm mode (typically Ink) when deactivating palm eraser.
Useful? React with 👍 / 👎.
| if (isPalmEraserActive) | ||
| { | ||
| isPalmEraserActive = false; | ||
| DisableEraserOverlay(); |
There was a problem hiding this comment.
The palm-eraser teardown calls DisableEraserOverlay() directly, which skips the EraserOverlay_PointerUp path that commits ReplacedStroke/AddedStroke to timeMachine in MW_Eraser.cs. In sessions where palm erase actually removes strokes, those erases are not recorded as a discrete undo/redo operation, so undo behavior becomes inconsistent compared with normal eraser input.
Useful? React with 👍 / 👎.
1 participant
No description provided.