Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions backend/tests/test_qa_self_healing.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,41 @@ def select(self, *cols, **kw):
importlib.reload(vector_store) # restore chroma default for other tests


def test_supabase_upsert_handles_numpy_arrays():
"""Ensure numpy ndarray embeddings do not cause TypeError when upserting to Supabase."""
os.environ["VECTOR_STORE"] = "supabase"
import importlib
importlib.reload(vector_store)

import numpy as np

class FakeSupabaseTable:
def __init__(self):
self.rows = {}
def upsert(self, row, on_conflict=None):
self.rows[row["id"]] = row
return self
def execute(self):
return types.SimpleNamespace(data=list(self.rows.values()), count=len(self.rows))

fake_table = FakeSupabaseTable()

try:
with mock.patch("db._get_client", lambda: mock.Mock(table=lambda name: fake_table)):
emb_array = np.array([0.1, 0.2, 0.3])
vector_store.upsert(
patient_key="anon_np",
ids=["id1"],
embeddings=[emb_array],
documents=["some doc"],
metadatas=[{"source": "test"}]
)
assert fake_table.rows["id1"]["embedding"] == [0.1, 0.2, 0.3]
finally:
os.environ.pop("VECTOR_STORE", None)
importlib.reload(vector_store)


if __name__ == "__main__":
fns = [v for k, v in sorted(globals().items()) if k.startswith("test_")]
for fn in fns:
Expand Down
15 changes: 12 additions & 3 deletions backend/vector_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,16 +151,21 @@ def _cosine(a: List[float], b: List[float]) -> float:
return -1.0
return dot / (na * nb)

def _supabase_upsert(patient_key: str, ids: List[str], embeddings: List[List[float]], documents: List[str], metadatas: List[Dict[str, Any]]):
def _supabase_upsert(patient_key: str, ids: List[str], embeddings: List[Any], documents: List[str], metadatas: List[Dict[str, Any]]):
client = _supabase_client()
# Upsert per chunk. Supabase doesn't have bulk upsert with jsonb vector easily,
# so we do per-row upsert. Chunk counts are small (20-30), so fine.
for i, cid in enumerate(ids):
emb = embeddings[i]
if hasattr(emb, "tolist"):
emb = emb.tolist()
elif not isinstance(emb, list):
emb = list(emb)
row = {
"id": cid,
"patient_key": patient_key,
"text": documents[i],
"embedding": embeddings[i], # stored as jsonb array
"embedding": emb, # stored as jsonb array
"metadata": metadatas[i],
}
# postgrest upsert on conflict (id)
Expand All @@ -176,7 +181,11 @@ def _supabase_upsert(patient_key: str, ids: List[str], embeddings: List[List[flo
raise
logger.info("Supabase upsert %d chunks for %s", len(ids), patient_key)

def _supabase_query(patient_key: str, query_embedding: List[float], n_results: int) -> Tuple[List[str], List[str], List[Dict[str, Any]]]:
def _supabase_query(patient_key: str, query_embedding: Any, n_results: int) -> Tuple[List[str], List[str], List[Dict[str, Any]]]:
if hasattr(query_embedding, "tolist"):
query_embedding = query_embedding.tolist()
elif not isinstance(query_embedding, list):
query_embedding = list(query_embedding)
client = _supabase_client()
try:
res = client.table("chunks").select("id, text, metadata, embedding").eq("patient_key", patient_key).execute()
Expand Down