Skip to content

Conversation

@Baptouuuu
Copy link
Member

Fix #7

@Baptouuuu Baptouuuu self-assigned this Jan 24, 2026
@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 95.83333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.18%. Comparing base (5f62465) to head (7ca9182).
⚠️ Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
src/Authority/UserInformation/Password.php 60.00% 2 Missing ⚠️
src/Path.php 71.42% 2 Missing ⚠️
src/Query.php 71.42% 2 Missing ⚠️
src/Authority/UserInformation/User.php 75.00% 1 Missing ⚠️
src/Fragment.php 75.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #11      +/-   ##
=============================================
- Coverage     100.00%   99.18%   -0.82%     
- Complexity       250      261      +11     
=============================================
  Files             33       33              
  Lines           1113     1227     +114     
=============================================
+ Hits            1113     1217     +104     
- Misses             0       10      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines -389 to -390
['http://127.0.0.1:80/', 'http', '', '', '127.0.0.1', '80', '/', '', ''],
['http://[::1]:80/', 'http', '', '', '[::1]', '80', '/', '', ''],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parsing no longer return the port as 80 is the default one for http

@Baptouuuu Baptouuuu marked this pull request as ready for review January 24, 2026 17:29
@Baptouuuu Baptouuuu merged commit d1bd57e into develop Jan 24, 2026
20 of 22 checks passed
@Baptouuuu Baptouuuu deleted the native-url-parsing branch January 24, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace league/uri-parser by PHP's new Uri API

2 participants