Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Promise API to make promise instances safer to use as one-argument callbacks, and bumps the library to v16.
Changes:
- Make
promise:__callresolve-only (single argument), removing the prior “nil + reason” rejection behavior. - Extend promise chaining utilities with additional
append/tail/resetbehaviors and tests. - Bump documented/project version references from 15 → 16.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
event/promise.lua |
Changes callable promise behavior and extends/adjusts pipeline helpers (append/tail/reset). |
test/test_promise.lua |
Updates tests for the new __call semantics and adds tests around append/tail/reset. |
README.md |
Bumps dependency link/version and adds V16 changelog notes for the Promise behavior changes. |
game.project |
Bumps project version to 16. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.