Skip to content

Release v4#11

Merged
Insality merged 12 commits intomainfrom
develop
Sep 27, 2025
Merged

Release v4#11
Insality merged 12 commits intomainfrom
develop

Conversation

@Insality
Copy link
Copy Markdown
Owner

@Insality Insality commented Jul 6, 2025

- [Breaking] Lang now use `lang.init()` function to initialize module instead of `game.project` configuration
- Add Lua file support
- Add CSV file support
- Updated editor script to collect unique characters from selected JSON and CSV files
- Add Lang debug properties page for Druid properties panel

Copilot AI review requested due to automatic review settings September 27, 2025 12:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the Defold Lang module to move from configuration-based initialization to programmatic initialization via lang.init(). The key changes include adding support for multiple file formats (JSON, Lua, CSV), removing game.project configuration dependencies, and consolidating test files.

  • Replaced game.project configuration with programmatic lang.init() function
  • Added support for Lua tables and CSV files in addition to JSON
  • Consolidated multiple test files into a single comprehensive test suite

Reviewed Changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/test_lang_logger.lua Removed separate logger test file
test/test_lang_error.lua Removed separate error handling test file
test/test_lang.lua Updated to use new init API and consolidated all tests
test/test.gui_script Removed references to deleted test files
lang/lang_internal.lua Added CSV support, moved type definitions, removed config-based setup
lang/lang_debug_page.lua Added new debug panel integration for Druid
lang/lang.proto Removed protobuf state definition
lang/lang.lua Major refactor to support programmatic initialization and multiple formats
lang/editor_script/lang.editor_script Extended to support CSV files for character acquisition
lang/csv.lua Added complete CSV parsing library
lang/annotations.lua Removed (type definitions moved to lang_internal.lua)
game.project Removed lang configuration section
example/ Added example Lua language files
README.md Updated documentation for new API and file format support
API_REFERENCE.md Regenerated API documentation
Comments suppressed due to low confidence (1)

lang/lang_internal.lua:1

  • The reference to lang_internal.DEFAULT_LANG will cause an error since DEFAULT_LANG is not defined in this module. This field should either be set to a string literal or the DEFAULT_LANG constant needs to be defined.
local csv = require("lang.csv")

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread lang/lang.lua Outdated
@Insality Insality changed the title Develop Release v4 Sep 27, 2025
@Insality Insality requested a review from Copilot September 27, 2025 12:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread lang/lang_internal.lua Outdated
Comment thread lang/lang.lua Outdated
Comment thread lang/lang.lua Outdated
Comment thread lang/lang.lua Outdated
Comment thread lang/lang.lua Outdated
@Insality Insality requested a review from Copilot September 27, 2025 14:20
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Insality Insality merged commit 9bcb026 into main Sep 27, 2025
1 check passed
This was referenced Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants