Skip to content

Develop#1

Merged
Insality merged 25 commits intomainfrom
develop
Dec 20, 2025
Merged

Develop#1
Insality merged 25 commits intomainfrom
develop

Conversation

@Insality
Copy link
Copy Markdown
Owner

@Insality Insality commented Jul 6, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 15, 2025 17:41
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the quest system by reorganizing the codebase into modular components, improving the event system with a unified queue architecture, and restructuring the test suite for better coverage. The changes enhance maintainability while preserving core functionality.

Key Changes:

  • Refactored monolithic quest module into separate modules (config, state, validation, lifecycle, quest_progress, logger, utils)
  • Unified event system using a single on_quest_event queue replacing multiple individual event callbacks
  • Reorganized tests into focused suites (core functionality, lifecycle, events, integration)

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
quest/quest.lua Main module refactored to use new modular architecture with simplified event queue
quest/quest/*.lua New modular components split from original quest_internal.lua
test/test_quest*.lua Test suite reorganized into separate files for different aspects of functionality
test/test.gui_script Updated test runner configuration to use new test files
example/*.lua Added example implementation with debug UI integration
game.project Updated dependencies and main collection for example

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread quest/internal/quest_validation.lua Outdated
Comment thread quest/internal/logger.lua Outdated
Comment thread test/test.gui_script Outdated
Comment thread quest/quest.lua Outdated
Comment thread quest/internal/quest_lifecycle.lua
Comment thread test/test_quest_integration.lua
@Insality Insality requested a review from Copilot October 16, 2025 22:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 6 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread quest/internal/quest_state.lua Outdated
Comment thread quest/internal/quest_utils.lua Outdated
Comment thread quest/internal/quest_validation.lua
Comment thread test/test.gui_script
Comment thread game.project
Comment thread quest/internal/quest_progress.lua
@Insality Insality requested a review from Copilot October 18, 2025 09:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread quest/internal/quest_lifecycle.lua
Comment thread quest/quest.lua
Comment thread quest/quest.lua Outdated
Comment thread settings_deployer Outdated
@Insality Insality requested a review from Copilot December 20, 2025 15:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 47 out of 47 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

widget/properties_panel/properties_panel.lua:1

  • Corrected spelling of 'contaienr' to 'container'.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread quest/internal/quest_utils.lua
@Insality Insality merged commit 462d641 into main Dec 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants