[F402] Warn on loop variable shadowing module name#272
Open
ansley wants to merge 2 commits intogh/"ansley"/2/basefrom
Hidden character warning
The head ref may contain hidden characters: "gh/"ansley"/2/head"
Open
[F402] Warn on loop variable shadowing module name#272ansley wants to merge 2 commits intogh/"ansley"/2/basefrom
ansley wants to merge 2 commits intogh/"ansley"/2/basefrom
Conversation
[ghstack-poisoned]
This was referenced Mar 8, 2023
amyreese
requested changes
Mar 8, 2023
Collaborator
amyreese
left a comment
There was a problem hiding this comment.
Needs formatting fixes (make format or hatch run lint:fix).
Collaborator
|
I think we need more variety of test cases, covering things like loops with multiple elements (or deep names), as well as some validating things like |
Author
|
I didn't see much in the pyflakes project (searched "shadow" and a few other keywords), but I did add more tests! |
[ghstack-poisoned]
amyreese
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
pyflakesdirectory #271