Extract node_comments to new module, return nodes instead of strings#450
Extract node_comments to new module, return nodes instead of strings#450amyreese wants to merge 3 commits intogh/amyreese/1/basefrom
Conversation
facebook-github-bot
added
the
CLA Signed
| self.module: Module = parse_module(source) | ||
| self.timings: Timings = defaultdict(lambda: 0) | ||
| self.wrapper = MetadataWrapper(self.module) |
There was a problem hiding this comment.
nit: you can always get back to the module with self.wrapper.module
|
Hi @amyreese! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
3 participants
Stack from ghstack (oldest at bottom):