Replace typing.List and other aliases w/ builtin equivalents after Python 3.10#496
Replace typing.List and other aliases w/ builtin equivalents after Python 3.10#496yangdanny97 wants to merge 4 commits intoInstagram:mainfrom
typing.List and other aliases w/ builtin equivalents after Python 3.10#496Conversation
|
Oh, I just realized this is almost a duplicate of #482 This one adds |
🤖 Automated Code Review📊 Pull Request Review SummaryOverviewThis pull request proposes a change to replace type annotations from the 🎯 Key Findings
🔍 Detailed Issues🔴 Critical IssuesNone found. 🟠 High Priority IssuesNone found. 🟡 Medium Priority IssuesNone found. 🟢 Low Priority IssuesNone found. ✅ Positive Aspects
📝 Overall AssessmentThis pull request is well-executed and enhances the clarity and maintainability of the codebase while promoting adherence to the latest Python standards. There are no issues found, and this PR can be merged without reservations. Great job to the author on these changes! ✅ No issues found! Code looks good.Generated by PR Review Agent |
Summary
This is the inverse of UseTypesFromTyping https://github.com/Instagram/Fixit/blob/main/src/fixit/rules/use_types_from_typing.py
In Python versions after 3.10, we can replace
typing.Listand other aliases with the builtin equivalents.Test Plan
makecloses #482