Implement dpnp.isin
#2595
Open
Implement dpnp.isin
#2595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndgrigorian
force-pushed
the
reuse-tensor-isin
branch
from
de4e3bb to
df81181
Compare
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2595/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_9 ran successfully. |
Collaborator
antonwolfy
reviewed
Oct 9, 2025
ndgrigorian
force-pushed
the
reuse-tensor-isin
branch
from
df81181 to
0b51fa3
Compare
ndgrigorian
force-pushed
the
reuse-tensor-isin
branch
4 times, most recently
from
07f280b to
7d29652
Compare
ndgrigorian
force-pushed
the
reuse-tensor-isin
branch
from
7d29652 to
42e9893
Compare
antonwolfy
reviewed
Nov 20, 2025
ndgrigorian
force-pushed
the
reuse-tensor-isin
branch
3 times, most recently
from
3200677 to
77d5512
Compare
ndgrigorian
force-pushed
the
reuse-tensor-isin
branch
from
77d5512 to
02dd391
Compare
antonwolfy
reviewed
Dec 14, 2025
| ) | ||
| usm_element = dpnp.get_usm_ndarray(element) | ||
| usm_test = dpnp.get_usm_ndarray(test_elements) | ||
| return dpnp.get_result_array( |
Contributor
There was a problem hiding this comment.
In that case we always know dpt.isin will return usm_ndarray:
Suggested change
| return dpnp.get_result_array( | |
| return dpnp_array._create_from_usm_ndarray( |
| ) | ||
| is None | ||
| ): | ||
| raise dpu.ExecutionPlacementError( |
Contributor
There was a problem hiding this comment.
Could you please add a test to cover that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages the recently-added
dpctl.tensor.isinto implementdpnp.isin