fix(api): pin the asset type when /assets/search has no filter - #132
Merged
Merged
Conversation
SearchBody.filter has no default where ResourceRetreiver.filter does, so a search body that omits the filter left pinAssetType nothing to write to. The query then ran across every node type, spent the limit on that mixed page, and dropped the non-assets afterwards — returning a handful of assets, or none, while matching ones sat past the cut. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: jgjesdal <jostein@intellistream.ai>
JosteinGj
marked this pull request as draft
September 18, 2026 13:07
olavgg
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SearchBody.filter has no default where ResourceRetreiver.filter does, so a search body that omits the filter left pinAssetType nothing to write to. The query then ran across every node type, spent the limit on that mixed page, and dropped the non-assets afterwards — returning a handful of assets, or none, while matching ones sat past the cut.
What this changes
How it was verified
Checklist
git commit -s), per CONTRIBUTING.md./gradlew buildpasses(see AGENTS.md for which of the two documentation sites it belongs in)