fix(tests): two live tests read the problem the api now sends - #133
Merged
Merged
Conversation
The api's errors series changed two refusals these tests still pinned to their old shape, and both fail against current datahub-platform main: - A delete that would strand a node is a 409 would-strand (api commit 7fbbb565), not a 400. AGENTS.md already says so. The test now checks the status and the problem type, and finds the stranded node in blockedBy instead of in the message. - Datapoints sent to a series that does not exist get a 404 not-found problem that lists the skipped series in `missing` (api #98). The old wording, "Could not find following timeseries", is gone. The test checks the problem type and that `missing` names the series. Both now read the problem's type and members rather than its prose, as problem_integration does, so rewording a detail cannot break them. The binary-path test is unchanged: the SDK raises that 404 itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Olav Groenaas Gjerde <olav@intellistream.ai>
JosteinGj
approved these changes
Sep 18, 2026
JosteinGj
added a commit
that referenced
this pull request
Sep 18, 2026
#133 moved the two Rust tests off the pre-unification error shapes but left their Python twins matching the string "Could not find following timeseries", which the api no longer sends. Both now assert the `not-found` problem type and find the absent series in the `missing` extension, the way the Rust test does. The 404 is a partial success: data-points for the other series in the batch were inserted, and `missing` names the ones that were skipped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: jgjesdal <jostein@intellistream.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The api's errors series changed two refusals these tests still pinned to their old shape, and both fail against current datahub-platform main:
missing(api build: add a script that builds the installable Python packages #98). The old wording, "Could not find following timeseries", is gone. The test checks the problem type and thatmissingnames the series.Both now read the problem's type and members rather than its prose, as problem_integration does, so rewording a detail cannot break them. The binary-path test is unchanged: the SDK raises that 404 itself.