Make the suites pass on any runner, whatever its drives and speed - #3
Merged
Merged
Conversation
CI failed twice more, and neither was the code under test. On x86_64, "the picker shows which controller each drive is on" wanted a row whose group was a SCSI host or "file". The runner that day had only an NVMe disk, grouped as nvme0, and an image never showed "file" at all: probe_device() returned for a regular file before probe_group(), which is what sets it. Images now get their group, so the picker says "file" beside them and the check holds on a machine with no disks of its own. On aarch64, "the JSON counts writes over budget" asserted 0 -- a claim about how fast the runner writes, and one write went over. It now checks that the count is there. The over-budget verdict checks resume from a checkpoint at the last chunk, which is read for real and cold from a file dd has just written; a budget of a minute keeps that read from turning the checkpoint's 5 into a 6. HDDSCAN_NO_TOOLS becomes HDDSCAN_TOOLS=none, and HDDSCAN_TOOLS=all keeps the missing-tools line off the form screenshot, so the picture no longer depends on what the machine drawing it has installed. The form shot is regenerated for the new group column; the dashboard shot for two dimmed spaces the wide-terminal change added. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failed twice more, and neither was the code under test.
On x86_64, "the picker shows which controller each drive is on" wanted a row whose group was a SCSI host or "file". The runner that day had only an NVMe disk, grouped as nvme0, and an image never showed "file" at all: probe_device() returned for a regular file before probe_group(), which is what sets it. Images now get their group, so the picker says "file" beside them and the check holds on a machine with no disks of its own.
On aarch64, "the JSON counts writes over budget" asserted 0 -- a claim about how fast the runner writes, and one write went over. It now checks that the count is there. The over-budget verdict checks resume from a checkpoint at the last chunk, which is read for real and cold from a file dd has just written; a budget of a minute keeps that read from turning the checkpoint's 5 into a 6.
HDDSCAN_NO_TOOLS becomes HDDSCAN_TOOLS=none, and HDDSCAN_TOOLS=all keeps the missing-tools line off the form screenshot, so the picture no longer depends on what the machine drawing it has installed. The form shot is regenerated for the new group column; the dashboard shot for two dimmed spaces the wide-terminal change added.