fix: resolve $ref and strip $defs/definitions/ref from tool schemas#10
Open
bulgadev wants to merge 2 commits into
Open
fix: resolve $ref and strip $defs/definitions/ref from tool schemas#10bulgadev wants to merge 2 commits into
bulgadev wants to merge 2 commits into
Conversation
02505f1 to
15bdeaf
Compare
sanitizeGeminiSchema() only stripped $ref but left $defs/definitions intact and never resolved $ref references inline. Added resolveRef() to inline $ref/ref references before sanitization. Added ref, $defs, definitions to unsupported keys. Added this.config.setModel(model) in sendMessageStream() so the model selected in OpenCode actually switches the Gemini model used. Added gemini-3.1-pro-preview, gemini-3.1-flash-lite, gemini-3-pro-preview, gemini-3-flash-preview to the /v1/models endpoint.
Clean modern README explaining the project, the $ref/defs fix, model switching, OpenCode integration, and crediting original fork and contributors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sanitizeGeminiSchema() only stripped $ref but left $defs/definitions intact, and never resolved $ref references inline. This caused the Gemini CodeAssist API to reject tool schemas with: 'Schema.ref was set alongside unsupported fields'.
Added resolveRef() to inline $ref/ref references from $defs/definitions before sanitization. Added ref, $defs, definitions to unsupported keys. Also handles exclusiveMinimum/exclusiveMaximum conversion.