Skip to content

Modify: Shared Exports & CTest (#987)#1195

Merged
xsscx merged 1 commit into
masterfrom
modify-abi-shared-exports
May 28, 2026
Merged

Modify: Shared Exports & CTest (#987)#1195
xsscx merged 1 commit into
masterfrom
modify-abi-shared-exports

Conversation

@xsscx
Copy link
Copy Markdown
Member

@xsscx xsscx commented May 28, 2026

PR Summary

#1193

- if(WIN32)
+ if(MSVC)

Checklist

  • Signed all Commits in PR
  • Built locally according to docs/build.md
  • Followed the guidelines in Contributing document
  • New source files include the ICC copyright and BSD 3-Clause license header
  • Code style matches nearby code: 2-space indent, K&R braces, m_ members

Legal Requirements

All official software projects hosted by the International Color Consoritum (ICC)
follows the open source software best practice policies. The International Color Consoritum IP policy governs ICC specification development and contributions to ICC open source software. Software contributions are also covered by the Contributor License Agreement (CLA).

Contributor License Agreements

Developers who wish to contribute code to be considered for inclusion
in ICC software must first complete a Contributor License Agreement
(CLA)
.

There is no cost or membership requirement to sign the ICC Contributor License Agreement (CLA). Please note that this is different from membership in the International Color Consortium (ICC). If your organization relies on our projects, please become a member. Membership dues are an essential source of funding and investment for these projects.

  • If you are an individual writing the code on your own time and you are SURE you are the sole owner of any intellectual property you contribute, you can sign the CLA as an individual contributor.

  • If you are writing the code as part of your job, or if there is any possibility that your employer might think they own any intellectual property you create, then you should use the Corporate Contributor Licence Agreement

License

ICC software is licensed under the BSD 3-Clause "New" or "Revised" License. Contributions to ICC software projects should abide by that license unless otherwised specified or approved by the ICC.

Copyright Notices

All new source files must begin with the ICC Copyright notice and include or reference the BSD 3-Clause "New" or "Revised" License.

INTELLECTUAL PROPERTY & PATENTS

Participation in ICC's development activities is subject to ICC's Patent Policy.

Maintainer Review Required

If you have questions, contact a listed Maintainer.

@xsscx xsscx linked an issue May 28, 2026 that may be closed by this pull request
@xsscx xsscx enabled auto-merge (squash) May 28, 2026 16:38
@github-actions github-actions Bot added Configuration Repository, CMake, YAML, JSON, or tool configuration Build Build system, CMake, compiler, or packaging pending CI checks still running passed All CI checks passed and removed pending CI checks still running labels May 28, 2026
@xsscx xsscx added this to the v2.3.2.1 milestone May 28, 2026
@xsscx xsscx disabled auto-merge May 28, 2026 21:40
@xsscx xsscx added Rebase Rebase in Progress. Please Do Not Make Changes. Resolving Merge Conflict Maintainer indicates in process Resolution of Merge Conflict. HOLD CHANGES labels May 28, 2026
@xsscx xsscx merged commit c3e9c67 into master May 28, 2026
23 checks passed
@xsscx xsscx removed Rebase Rebase in Progress. Please Do Not Make Changes. Resolving Merge Conflict Maintainer indicates in process Resolution of Merge Conflict. HOLD CHANGES labels May 28, 2026
@xsscx xsscx deleted the modify-abi-shared-exports branch May 29, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Build system, CMake, compiler, or packaging Configuration Repository, CMake, YAML, JSON, or tool configuration passed All CI checks passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify: Shared Exports & CTest (#987)

2 participants