remove mu2 from PoP, following IETF draft#629
Merged
Conversation
perturbing
force-pushed
the
perturbing/leios-ietf-pop-fix
branch
from
267c662 to
a0f1caa
Compare
perturbing
force-pushed
the
perturbing/leios-ietf-pop-fix
branch
from
a0f1caa to
3f78056
Compare
lehins
approved these changes
May 21, 2026
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Sorry for taking so long to getting to review this PR.
I don't know why mu2 was used to begin with. So, ignoring my understanding of cryptographic reasoning for this change, these PR look good.
perturbing
force-pushed
the
perturbing/leios-ietf-pop-fix
branch
2 times, most recently
from
da3753d to
302e0d5
Compare
Member
Author
|
Rebased 👍 |
perturbing
force-pushed
the
perturbing/leios-ietf-pop-fix
branch
from
302e0d5 to
91032d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #625
Just for safety, this PR is split into three commits to ensure that in these intermediate steps, all test still pass. As an overview, in commit:
signDIGNverifyDSIGNCommit 2 and 3 reduce the FFI surface we use. Also note that throughout the whole test, we have a full round of PoP creation and verification under the hood here. The passing of each committee implies that functionally we did not change anything.