Fix various issues in Dijkstra CddlSpec to make all the tests pass#5779
Open
Soupstraw wants to merge 9 commits into
Open
Fix various issues in Dijkstra CddlSpec to make all the tests pass#5779Soupstraw wants to merge 9 commits into
Soupstraw wants to merge 9 commits into
Conversation
bb16935 to
18abd91
Compare
43eca9a to
2b2085f
Compare
251f6bc to
21f3437
Compare
98ebbfa to
8fe7ccd
Compare
Lucsanszky
reviewed
May 23, 2026
bd0e8a1 to
d7b4f58
Compare
Lucsanszky
reviewed
May 25, 2026
lehins
reviewed
May 25, 2026
Comment on lines
+738
to
+740
| forall name a. | ||
| (KnownSymbol name, IsType0 a) => Proxy name -> Int -> (Term -> Term -> Bool) -> a -> GRuleCall | ||
| mkMaybeTaggedSet pname n eq = binding $ \x -> |
Collaborator
There was a problem hiding this comment.
(As discussed on a call) Term has an Ord instance, so the natural questions comes to mind:
- why do we need to pass custom
eqfunction as an argument, which is always set to(==)? - Why do we use
O(n^2)complexity functionnubOrd, when we could just use theOrdand stick those in aSet?
Suggested change
| forall name a. | |
| (KnownSymbol name, IsType0 a) => Proxy name -> Int -> (Term -> Term -> Bool) -> a -> GRuleCall | |
| mkMaybeTaggedSet pname n eq = binding $ \x -> | |
| forall name a. | |
| (KnownSymbol name, IsType0 a) => Proxy name -> Int -> a -> GRuleCall | |
| mkMaybeTaggedSet pname n = binding $ \x -> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes various issues in
Dijkstra'sCddlSpecto make the tests pass. The PR is intended to be reviewed commit-by-commit.Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).