Add aggregator CLI commands for configuration parameters - #3438
Draft
turmelclem wants to merge 15 commits into
Draft
Add aggregator CLI commands for configuration parameters#3438turmelclem wants to merge 15 commits into
turmelclem wants to merge 15 commits into
Conversation
…rsion, signature and generating tx datum for protocol configuration command
…ct to avoid missing signing when generating protocol config tx datum
…empty read impl for cardano chain adapter
…s with fallback logic for ProtocolConfigurationReader
…urn type for ProtocolConfigurationReader
…rt and on chain configurations
protocol configutation markers
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
…ion consistency for protocol-configuration import command
…m, and rework protocol-configuration command parameters
…eader, and using dedicated struct for CBOR conversion
| @@ -0,0 +1,8 @@ | |||
| pub mod message; | |||
| @@ -0,0 +1,8 @@ | |||
| pub mod message; | |||
| pub mod payload; | |||
| @@ -0,0 +1,8 @@ | |||
| pub mod message; | |||
| pub mod payload; | |||
| pub mod protocol_configuration_reader; | |||
| use crate::model::ConfigurationComputerFromMarkers; | ||
|
|
||
| /// Cardano Chain reader retrieves protocol configuration markers on chain | ||
| pub struct CardanoChainProtocolConfigurationMarkersReader { |
|
|
||
| /// Cardano Chain reader retrieves protocol configuration markers on chain | ||
| pub struct CardanoChainProtocolConfigurationMarkersReader { | ||
| address: ChainAddress, |
| /// Cardano Chain reader retrieves protocol configuration markers on chain | ||
| pub struct CardanoChainProtocolConfigurationMarkersReader { | ||
| address: ChainAddress, | ||
| chain_observer: Arc<dyn ChainObserver>, |
| pub struct CardanoChainProtocolConfigurationMarkersReader { | ||
| address: ChainAddress, | ||
| chain_observer: Arc<dyn ChainObserver>, | ||
| verification_key: ProtocolConfigurationMarkersVerifierVerificationKey, |
| #![warn(missing_docs)] | ||
| //! This crate provides mechanisms to read and check the configuration parameters of a Mithril network. | ||
|
|
||
| pub mod cardano_chain; |
| Ok(protocol_configuration_markers_reader) | ||
| } | ||
|
|
||
| /// [ProtocolConfigurationReader] service |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
aggregator cli :
protocol-config
Pre-submit checklist
Issue(s)
this PR closes #3392