Conversation
2af820a to
f8a2239
Compare
fabiobrz
left a comment
There was a problem hiding this comment.
Thanks for this PR @tommaso-borgato - I've dropped some comments because it looks like we need to check and add back some tests.
| @@ -0,0 +1 @@ | |||
| /interface=management:write-attribute(name=inet-address, value="${jboss.bind.address.management:0.0.0.0}") | |||
There was a problem hiding this comment.
kafka-application is not bootable, so why do we add this configuration? I recall we discussed it already, and it seems to me we said it is required for bootable jar applications only, or am I missing something?
@jfdenise - do you have any hints about adding this specific configuration?
There was a problem hiding this comment.
@fabiobrz , I can see the kafka application being built as bootable JAR:
I suspect that the usage of this script is due to wildfly/wildfly-cloud-galleon-pack#65 that has been fixed recently in the cloud feature-pack.
I plan to do a new release today of the cloud FP before WildFly 40.Final, this script will become useless.
There was a problem hiding this comment.
@fabiobrz @tommaso-borgato I have just released cloud feature-pack 9.2.2.Final
There was a problem hiding this comment.
9.2.2.Final
Thank you @jfdenise; I suppose we should wait deleting management.cli until EAP versions we test include these changes, right?
There was a problem hiding this comment.
Are you already testing EAP 8.2 with bootable JAR? The PROD produced cloud FP is not ready for Bootable JAR support, so such tests shouldn't be runnable yet.
Bootable JAR support for Openshift for EAP 8.2 is currently a WIP RFE, QE is testing a wip branch that includes this fix already: https://github.com/jfdenise/eap-cloud-galleon-pack/tree/bootable-in-cloud-fp
So theoretically, you should delete this management.cli script, not needed when Bootable JAR for Openshift will be ready.
There was a problem hiding this comment.
@jfdenise Thank you, we are refining these tests using wildfly ... we can get rid of scripts once https://github.com/jfdenise/eap-cloud-galleon-pack/tree/bootable-in-cloud-fp is merged and released right?
There was a problem hiding this comment.
@tommaso-borgato , we just got the pre-check, I will merge soon.
83e9f51 to
2ca9327
Compare
f6b4c8c to
9daf58a
Compare
…d Tests wildfly-cloud-galleon-pack 9.2.2.Final
fabiobrz
left a comment
There was a problem hiding this comment.
LGTM, thanks for the great work here @tommaso-borgato, merging!
Resolves #94
Coupled with Intersmash/intersmash-tests#86
Description
New Application to be used in Apache Kafka related Tests:
Ci Runs:
Type of change
test, version modification, documentation, etc.)
Checklist