docs: document TRUSTED_PROXIES for reverse-proxied installs - #27
Merged
Merged
Conversation
A narrowed TRUSTED_PROXIES must name the address the container sees, not the proxy's LAN address; naming the wrong one makes InvoiceShelf discard X-Forwarded-Proto and generate http:// links behind an https site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2.x half of the same trap as InvoiceShelf/InvoiceShelf#500. 2.x has the identical
TRUSTED_PROXIESdefault and the identical failure mode: people list their reverse proxy's LAN address, the container sees the Docker bridge gateway instead,X-Forwarded-Protois discarded, and the app generateshttp://links behind an https site.FORCE_HTTPSis deliberately left out here, since that setting only exists on 3.x. The 3.x page gets both in #26.