Accessibility and right-to-left layouts - #15
Merged
Merged
Conversation
- The view switcher keeps its labels for screen readers on phones, where only the icons show; its group has a name of its own. - Modal close icons are buttons, row menus say which task or project they act on, colour swatches are named and report which one is chosen, and the week arrows, status selects and unbilled checkboxes have names. - A task card opens from its title button as well as by click, so the board works from a keyboard; status changes stay in the task form. - Layout classes are logical (ms-, pe-, text-end, border-e, end-5), so a right-to-left host language mirrors the module with the rest of the app. - eslint-plugin-vuejs-accessibility runs in pnpm run lint with the host's rules, at zero warnings. Nothing here needs a newer host: the labels ride on props every supported host accepts, and older hosts ignore the ones they do not know.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the module in line with the host's accessibility and RTL work (InvoiceShelf/InvoiceShelf#804).
ms-,pe-,text-end,border-e,end-5), so the module mirrors when the host runs in Arabic, Persian, Hebrew or Urdu.eslint-plugin-vuejs-accessibilitynow runs inpnpm run lint, with the host's rules.Works on every host in the compatibility range: it only passes props those hosts accept, and older hosts ignore the ones they don't know. No version bump; the release is separate.