Empty screens drawn like the host's - #16
Merged
Merged
Conversation
The host's empty states now show a small line drawing in the logo's style. The module's empty screens (tasks, the board without statuses, projects, unbilled time and reports) get drawings of their own in the same style, in place of a grey icon. They go in the empty placeholder's default slot, which every host in the compatibility range renders, and take their colours from the host's CSS variables, so they follow light and dark without relying on anything newer than 3.0.0-alpha.2.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host's empty states now show line drawings (InvoiceShelf/InvoiceShelf#810). This gives the module's empty screens drawings of their own in the same style, in place of the grey icon: tasks, the board with no statuses, projects, unbilled time and reports.
They use the placeholder's default slot and the host's CSS colour variables, both available on every host from 3.0.0-alpha.2, so older hosts show them too. The host's new faded placeholder rows aren't used, because older hosts don't have them.