Faded placeholder rows on the empty lists - #17
Merged
Merged
Conversation
The host's empty lists sit in a card of faded rows shaped like the table to come, through the placeholder's ghost prop (host 3.0.0-alpha.4). The module's tasks, projects, reports and unbilled time lists now ask for the same, sized to their own columns, so they match the host's pages. An older host doesn't know the prop and draws the empty state as before, so AGENTS.md now allows a newer prop when a host that ignores it still renders correctly.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module's empty tasks, projects, reports and unbilled time lists now show the host's card with faded placeholder rows (the placeholder's
ghostprop), so they match the host's list pages.Hosts before 3.0.0-alpha.4 don't have the prop and show the empty state as before, without the rows. AGENTS.md now allows a newer prop in that case: when a host that ignores it still renders correctly.