Release 0.2.1: creating a task works on PostgreSQL - #20
Merged
Merged
Conversation
The next task number was read with max() under FOR UPDATE, which PostgreSQL refuses, so no task could be created there and the demo's sample data failed. The row with the highest number is read and locked instead. CI now also runs the suite on PostgreSQL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.2.0 read the next task number with
max()underFOR UPDATE, which PostgreSQL refuses, so no task could be created on a PostgreSQL install and the public demo's sample data (and with it the demo reset) failed. The row with the highest number is now read and locked instead.CI also runs the suite on PostgreSQL now: the test harness takes the database from
DB_*whenDB_CONNECTION=pgsqland stays on SQLite in memory otherwise. The old query fails that job; the new one passes it.Checked with the 3.0.0-alpha.7 image on PostgreSQL 18: the demo reset installs this version and seeds its projects, tasks and time. Tag
0.2.1on the merge commit.