Release zips carry the built assets again - #14
Merged
Merged
Conversation
Yarn 1 refuses to run inside an InvoiceShelf 2.x checkout, whose package.json names pnpm as its packageManager, and artifact-gen.sh went on to zip the module without dist/, so v1.1.4 was published with no JavaScript or CSS. The script now builds with npm, stops at the first failure and refuses to zip without dist/. release.yaml can also be run by hand for an existing tag to rebuild and replace its zip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.1.4 zip was published without
dist/: Yarn 1 refuses to run inside the InvoiceShelf 2.x checkout (its package.json names pnpm aspackageManager), andartifact-gen.shzipped the module anyway. The broken asset has been removed from the release.artifact-gen.shbuilds with npm, stops at the first failure (set -euo pipefail) and refuses to zip withoutdist/style.css.release.yamlcan be run by hand with ataginput to rebuild and replace the zip of an existing release. After merging, that rebuilds v1.1.4.Checked by running the script from the root of a 2.x checkout, as the workflow does: the zip includes
dist/.