[BUG]Add Jerk parameter to movement in service#43
Conversation
* rendering Kuka Krc4Ecat service view
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug by adding the missing Jerk parameter to movement operations in service view models. The changes also correct inheritance relationships in the Kuka robotics WPF implementation.
- Adds Jerk parameter synchronization for all axes in single and multi-axis movement operations
- Fixes incorrect class inheritance in TcoKrc4_Ecat view model classes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| TcoKrc4_Ecat_v_5_x_xServiceViewModel.cs | Corrects TcoKrc4_Ecat_v_5_x_xViewModel to inherit from TcoKrc4_Ecat_v_5_x_xServiceViewModel instead of TcoKrc4_v_5_x_xServiceViewModel |
| TcoKrc4_ECat_v_5_x_xServiceView.xaml.cs | Updates DataContext initialization to use TcoKrc4_Ecat_v_5_x_xServiceViewModel instead of TcoKrc4_v_5_x_xServiceViewModel |
| TcoSingleAxisServiceViewModel.cs | Adds Jerk parameter synchronization in MoveToPosition method for single axis operations |
| TcoMultiAxisServiceViewModel.cs | Adds Jerk parameter synchronization in MoveToPosition method for all four axes (Axis1-4) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| this.Component._axis1._moveAbsoluteTask._jerk.Synchron = SelectedItem.Axis1.Jerk.Synchron; | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] The Jerk parameter is placed after Deceleration but before the Axis1MoveAllowed check. For consistency with the existing parameter pattern (Position, Velocity, Acceleration, Deceleration), consider moving the blank line 210 to after the Jerk assignment to maintain the same spacing pattern as other parameters.
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] The Jerk parameter is placed after Deceleration with an extra blank line. For consistency with the existing parameter pattern (Position, Velocity, Acceleration, Deceleration), consider removing the blank line 181 to maintain the same spacing as the parameters above.
closes #42