[NEW-FEATURE] Add SetSignal method to TcoDo component in TcoElements library#44
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds new suspend functionality to the TcoDo component in the TcoElements library, allowing conditional suspension of digital output signals. The changes enable users to temporarily disable outputs based on runtime conditions with appropriate warning messages.
Changes:
- Added two new methods (
SuspendandSuspendExpression) to conditionally suspend digital output signals - Introduced a new private field
_sbof typeTcoCore.StringBuilderfor message formatting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <Declaration><![CDATA[(*~ | ||
| <docu> | ||
| <summary> | ||
| Suspend the turning to next position when the condition is 'true'. Task is still bussy |
There was a problem hiding this comment.
Corrected spelling of 'bussy' to 'busy'.
| Suspend the turning to next position when the condition is 'true'. Task is still bussy | |
| Suspend the turning to next position when the condition is 'true'. Task is still busy |
| </summary> | ||
| <remarks> | ||
| <note type="warning"> | ||
| The call of this method will be effective only when called AFTER the initialization of the instance of given TcoCarousel. |
There was a problem hiding this comment.
The documentation references 'TcoCarousel' but this method is in the TcoDo component. This appears to be copy-pasted documentation that should be updated to reference TcoDo instead.
| The call of this method will be effective only when called AFTER the initialization of the instance of given TcoCarousel. | |
| The call of this method will be effective only when called AFTER the initialization of the instance of given TcoDo. |
| (*~ | ||
| <docu> | ||
| <summary> | ||
| Condition to suspend the movement of the carousel can be inverted by this parameter. |
There was a problem hiding this comment.
The documentation references 'carousel' but this is a digital output component (TcoDo), not a carousel. Update documentation to reflect the actual component purpose.
| ]]></Declaration> | ||
| <Implementation> | ||
| <ST><![CDATA[IF (_setTask.Busy OR _signal ) AND inDisableCondition THEN | ||
| Messenger.Warning(CONCAT('<#Ouput signal is suspended due to#> : ' , inMessage)); |
There was a problem hiding this comment.
Corrected spelling of 'Ouput' to 'Output'.
| Messenger.Warning(CONCAT('<#Ouput signal is suspended due to#> : ' , inMessage)); | |
| Messenger.Warning(CONCAT('<#Output signal is suspended due to#> : ' , inMessage)); |
closes #39